https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2695
--- Comment #4 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-07-17 06:02:08 PDT ---
(In reply to comment #3)
> Created attachment 8788 [details]
> Updated WiMAXMAXPHY dissector
> Updated code to be a "modern" plugin. Thought maybe this could be a built-in,
> but there was already existing WiMax plugins, and I didn't really want to
> convert them all without consultation.
> Fixed the combinations of tvb_get_* + proto_tree_add_* and drastically reduced
> the "whitespace". More "whitespace" can be removed with reformatting of the hf
> array (perl isn't my strong suit, but it appears someone has been reformatting
> hf arrays on the trunk, but I don't see anything in the "tools" directory to do
> it myself)
> Wanted to work with the Python script to generate traffic to test dissector
> before committing. Any "real" traffic would also be appreciated.
> Since I haven't written a plugin before, comments are certainly welcome. I'm
> fairly confident with the dissector code, its the other stuff I'm not sure I
> updated correctly.
Looks OK to me, commit and see what happens :-))
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.