Wireshark-bugs: [Wireshark-bugs] [Bug 7451] New: Possible reassembly issue in packet-smb-pipe.c

Date: Sun, 8 Jul 2012 11:15:03 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7451

           Summary: Possible reassembly issue in packet-smb-pipe.c
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Dissection engine (libwireshark)
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: eapache@xxxxxxxxx


Build Information:
wireshark 1.9.0 (SVN Rev Unknown from unknown)

Copyright 1998-2012 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.24.10, with Cairo 1.12.2, with Pango 1.30.1, with
GLib 2.33.3, with libpcap, with libz 1.2.7, with POSIX capabilities (Linux),
without libnl, with SMI 0.4.8, with c-ares 1.9.1, without Lua, without Python,
with GnuTLS 2.12.14, with Gcrypt 1.5.0, with MIT Kerberos, with GeoIP, with
PortAudio V19-devel (built Dec 10 2011 11:43:10), with AirPcap.

Running on Linux 3.5.0-3-generic, with locale en_CA.UTF-8, with libpcap version
1.3.0, with libz 1.2.7, GnuTLS 2.12.14, Gcrypt 1.5.0, without AirPcap.

Built using gcc 4.7.1.
--
Currently the variable hash_key is defined and set but never used in
dissect_pipe_dcerpc() at line 3279.

Based on the comments, it should perhaps be used instead of 'fid' as the hash
key for all of the fragment_* reassembly calls. The only advantage it has over
fid is that it embeds a flag for the direction, but it seems to me that the
reassembly library already handles that internally. If that is true then it can
be removed completely.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.