Wireshark-bugs: [Wireshark-bugs] [Bug 7389] New: IO Graphs do not insert thousands markers in la

Date: Thu, 21 Jun 2012 06:47:06 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7389

           Summary: IO Graphs do not insert thousands markers in labels on
                    tick marks for each axis
           Product: Wireshark
           Version: 1.9.x (Experimental)
          Platform: x86
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: realrichardsharpe@xxxxxxxxx


Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
It can be very hard to tell at a glance whether the number is 10M, 1M or
100,000.

The following simple patch seems to fix that. Since the local stuff is already
initialized, this should work for those locales where "," is used as the
thousands separator as well as those where "." is used. It might even work in
those locales where they separate by 10,000s(eg, Chinese) and not thousands.

Index: ui/gtk/io_stat.c
===================================================================
--- ui/gtk/io_stat.c    (revision 43186)
+++ ui/gtk/io_stat.c    (working copy)
@@ -962,14 +962,14 @@
                 if(draw_y_as_time){
                     print_time_scale_string(label_string, 15, value, value,
TRUE);
                 } else {
-                    g_snprintf(label_string, 15, "%d", value);
+                    g_snprintf(label_string, 15, "%'d", value);
                 }
             } else {
                 value = (max_y/10)*i;
                 if(draw_y_as_time){
                     print_time_scale_string(label_string, 15, value, max_y,
FALSE);
                 } else {
-                    g_snprintf(label_string, 15, "%d", value);
+                    g_snprintf(label_string, 15, "%'d", value);
                 }
             }

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.