Wireshark-bugs: [Wireshark-bugs] [Bug 7260] New dissector for WSE Remote Ethernet protocol

Date: Thu, 17 May 2012 11:53:03 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7260

Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexis.lagoutte@xxxxxxxxx

--- Comment #6 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-05-17 11:53:02 PDT ---
Hi Clement,

Thanks for the license update but the code don't compile under Linux 
Missing file modification (configure.in, plugins/Makefile.am) there is also
some modification is not needed ( all.vcproj, wireshark.sln)
plugins/wreth/Makefile.am:35: `hsapi.la' is not a standard libtool library name
plugins/wreth/Makefile.am:35: did you mean `libhsapi.la'?
plugins/wreth/Makefile.am:42: variable `wreth_la_LDFLAGS' is defined but no
program or
plugins/wreth/Makefile.am:42: library has `wreth_la' as canonic name (possible
typo)
plugins/wreth/Makefile.am:43: variable `wreth_la_LIBADD' is defined but no
program or
plugins/wreth/Makefile.am:43: library has `wreth_la' as canonic name (possible
typo)
make: *** [Makefile.in] Error 1

There is a reason to not make a build-in dissector ?

Please use proto_tree_add_item 
example : 
+        /*Size*/
+        proto_tree_add_uint(pWrethTree, hf_Wreth_Size, tvb, offset + 2, 2,
tvb_get_letohs(tvb,offset+2));
Replace by
+        /*Size*/
+        proto_tree_add_item(pWrethTree, hf_Wreth_Size, tvb, offset + 2, 2,
ENC_LITTLE_ENDIAN);
...

+        switch(functionCode)
+        {
+            case WRETH_IDENT:
+                pString = "Identification";
+                break;
[...]
+            default:
+                break;
+        }
+        
+        /*Function code*/
+        proto_tree_add_uint_format(pWrethTree, hf_Wreth_FunctionCode, tvb,
offset + 4, 2, functionCode, 
+                "Function code (%d) : %s", functionCode, pString);

Look dev.guide about use value_string type.
Some issue for Status.* and Code.* file (use value_string)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.