Wireshark-bugs: [Wireshark-bugs] [Bug 6878] Overhaul of tvb_get_bitsxx() functions

Date: Wed, 4 Apr 2012 14:54:40 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6878

Gerald Combs <gerald@xxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gerald@xxxxxxxxxxxxx

--- Comment #13 from Gerald Combs <gerald@xxxxxxxxxxxxx> 2012-04-04 14:54:39 PDT ---
(In reply to comment #11)
> In this case Coverity is (I believe) wrong, as line 1782 is guaranteeing that
> total number of bits is less than 8.  
> 
> Is Coverity pacified by adding an assertion to this effect?

It looks like total_no_of_bits can be greater than 8 if bit_offset is negative.
I checked in a change in r41945 to make bit_offset unsigned. Hopefully this
will fix the CIDs.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.