Wireshark-bugs: [Wireshark-bugs] [Bug 7020] Review use of proto_tree_add_text in packet-eap.c

Date: Wed, 4 Apr 2012 03:36:56 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7020

--- Comment #14 from Anders Broman <anders.broman@xxxxxxxxxxxx> 2012-04-04 03:36:55 PDT ---
(In reply to comment #13)
> (In reply to comment #12)
> > Again, it was done like that for consistency. The existing code used eaptls and
> > not eap.tls
> > 
> > Thoughts?
> Yes, but it is not good... 
> Checkfiltername.pl tools is not happy :
> 1233 eap_md5.value doesn't match PROTOABBREV of eap
> 1236 eap_tls.flags doesn't match PROTOABBREV of eap
> 1239 eap_tls.flags.len_included doesn't match PROTOABBREV of eap
> 1242 eap_tls.flags.more_fragments doesn't match PROTOABBREV of eap
> 1245 eap_tls.flags.start doesn't match PROTOABBREV of eap
> 1248 eap_tls.flags.version doesn't match PROTOABBREV of eap
> 1251 eap_tls.len doesn't match PROTOABBREV of eap
> 1254 eap_tls.fragment doesn't match PROTOABBREV of eap
> 1258 eap_tls.fragments doesn't match PROTOABBREV of eap
> 1262 eap_tls.fragment.overlap doesn't match PROTOABBREV of eap
> 1266 eap_tls.fragment.overlap.conflict doesn't match PROTOABBREV of eap
> 1270 eap_tls.fragment.multipletails doesn't match PROTOABBREV of eap
> 1274 eap_tls.fragment.toolongfragment doesn't match PROTOABBREV of eap
> 1278 eap_tls.fragment.error doesn't match PROTOABBREV of eap
> 1282 eap_tls.fragment.count doesn't match PROTOABBREV of eap
> 1286 eap_tls.reassembled.length doesn't match PROTOABBREV of eap


Change to use eap. in filter names isof eap_ comitted in revision 41921.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.