Wireshark-bugs: [Wireshark-bugs] [Bug 6975] New: H264 nal are not unescaped so they are shown as

Date: Wed, 21 Mar 2012 02:07:05 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6975

           Summary: H264 nal are not unescaped so they are shown as
                    Malformed Packets
           Product: Wireshark
           Version: 1.6.5
          Platform: x86-64
        OS/Version: Windows 7
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: sergio.garcia.murillo@xxxxxxxxx


Build Information:
Version 1.6.5 (SVN Rev 40429 from /trunk-1.6)

--
When parsing the h264 (mainly SPS) wireshark does not take into account NAL
scape codes:

static uint8_t *x264_nal_escape_c( uint8_t *dst, uint8_t *src, uint8_t *end )
{
    if( src < end ) *dst++ = *src++;
    if( src < end ) *dst++ = *src++;
    while( src < end )
    {
        if( src[0] <= 0x03 && !dst[-2] && !dst[-1] )
            *dst++ = 0x03;
        *dst++ = *src++;
    }
    return dst;
}


So the "malformed" SPS

0xae875025  42 C0 0D DA 05 82 5A 10 00 00 03 00 10 00 00 03  
0xae875035  03 28 F1 42 AA 

Becames a correct one afer unescaping:
0xae6f0020  42 C0 0D DA 05 82 5A 10 00 00 00 10 00 00 03 28  
0xae6f0030  F1 42 AA

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.