Wireshark-bugs: [Wireshark-bugs] [Bug 6877] New: EAP-SIM and EAP-AKA are missing some attributes

Date: Mon, 27 Feb 2012 19:50:58 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6877

           Summary: EAP-SIM and EAP-AKA are missing some attributes
           Product: Wireshark
           Version: 1.7.x (Experimental)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: jmedved@xxxxxxxxxxx


Created attachment 7905
  --> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7905
Changes to EAP-SIM and EAP-AKA attributes

Build Information:
Version 1.7.1-SVN-41145 (SVN Rev 41145 from /trunk)

Copyright 1998-2012 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.22.1, with Cairo 1.10.2, with Pango 1.28.3, with
GLib 2.26.1, with WinPcap (4_1_2), with libz 1.2.5, without POSIX capabilities,
with SMI 0.4.8, with c-ares 1.7.1, with Lua 5.1, without Python, with GnuTLS
2.10.3, with Gcrypt 1.4.6, without Kerberos, with GeoIP, with PortAudio
V19-devel (built Feb 22 2012), with AirPcap.

Running on 64-bit Windows 7 Service Pack 1, build 7601, with WinPcap version
4.1.2 (packet.dll version 4.1.0.2001), based on libpcap version 1.0 branch
1_0_rel0b (20091008), GnuTLS 2.10.3, Gcrypt 1.4.6, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 21022

--
Existing EAP-AKA and EAP-SIM dissector is missing AT_NONCE_MT, AT_VERSION_LIST,
AT_SELECTED_VERSION, AT_BIDDING, AT_IPMS_IND, AT_IPMS_RES and AT_TRUST_IND
attribute definitions.

I added those new definitions in existing value_string array. 


Both EAP methods are using same "IANA number space"
(http://www.iana.org/assignments/eapsimaka-numbers/eapsimaka-numbers.xml). Both
are closely related with most of attributes being shared between them and ones
that are not being shared being explicitly reserved for same functionality in
other's RFC (e.g. AT_VERSION_LIST is referenced from EAP-AKA specification
although it is currently only used in EAP-SIM).

That is why I also refactored code by extracting their definitions from
function level and adjusting val_to_str conversion accordingly.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.