Wireshark-bugs: [Wireshark-bugs] [Bug 6155] Dissector for the USB Integrated Circuit Card Interf

Date: Tue, 24 Jan 2012 12:58:54 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6155

--- Comment #26 from Tyson Key <tyson.key@xxxxxxxxx> 2012-01-24 12:58:54 PST ---
(In reply to comment #15)
> A relatively minor question:
> 
> This dissector uses "USBCCID" for COL_PROTO and "ccid...." for the filter
> names.
> 
> I found this slightly confusing when I tried to filter for "USBCCID" frames in
> a capture since I first assumed that the filter name would be "usbccid".
> 
> I note that the usbhid, usbhub and usb-mass-storage dissectors use
> "USBXXX" & etc for COL_PROTO & "usbxxx..." & etc for the filter names.
> 
> How would you feel about changing the usb-ccid dissector to use "usbccid..."
> for the filter names ?
> 
> 
> I do note that the usb-at dissector uses "USB/AT" (I think) for COL_PROTOCOL,
> and "at..." as the filter names.  It seems to me that it would be more
> consistent to also change this dissector to use "USBAT" & "usbat..." instead.
> 
> 
> What are your thoughts ?
> 
> Bill

Having thought about things since then, I'm happy with updating "CCID"
references to "USBCCID" - and attached a patch to Bug 6752 with an
implementation of that change.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.