Wireshark-bugs: [Wireshark-bugs] [Bug 6705] Multipath TCP Patch to packet-tcp.c

Date: Tue, 3 Jan 2012 05:06:50 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6705

Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexis.lagoutte@xxxxxxxxx

--- Comment #1 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2012-01-03 05:06:49 PST ---
Hi,

It is possible to add a trace of MultiPath TCP ? 

+            ti = proto_tree_add_text(mptcp_tree, tvb, offset,
+                        hf_tcp_option_len, "MPTCP Flags: %d", flags);
Use proto_tree_add_uint (also the 4th attribut is the length of the field,
don't use the value of header field !)

There is also some Clang Warning 

ANALYZE: packet-tcp.c dissect_tcpopt_mptcp
packet-tcp.c:2648:21: warning: Value stored to 'offset' is never read
packet-tcp.c:2759:17: warning: Value stored to 'offset' is never read
packet-tcp.c:2793:13: warning: Value stored to 'offset' is never read
packet-tcp.c:2620:21: warning: Value stored to 'offset' is never read
packet-tcp.c:2725:17: warning: Value stored to 'offset' is never read
packet-tcp.c:2589:17: warning: Value stored to 'offset' is never read
packet-tcp.c:2784:17: warning: Value stored to 'offset' is never read
packet-tcp.c:2768:13: warning: Value stored to 'offset' is never read

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.