https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5881
--- Comment #22 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-12-21 02:15:57 PST ---
(In reply to comment #21)
> Created an attachment (id=7565)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7565) [details]
> MIH protocol dissector patch
>
> 1)It is not possible to replace proto_tree_add_text by proto_tree_add_item ?
> (Make field filterable ?
> --> the proto_tree_add_text at line no. 591 (for dissection of MIH type), is
> used to make the output more readable. However the MIh type field is
> filterable, because it is used when the corresponding tree is expanded.
> --> If there is anywhere else I have to change the API please let me know the
> line number.
>
line : 638, 641, 645, 651, 654, 656, 659, 668 1765, 1777, 1787, 1792, 1800...
> 2)Also for function dissect_cmd_list / dissect_evt_list / dissect_mob_mgmt /
> dissect_cfg_mthds, why not use value_string ?
> --> A value_string datatype cannot be used because these functions dissect a
> Bitmap, ie, each bit specifies whether the corresponding event is supported, so
> all the if conditions are to be checked. If there is any better solution please
> let me know.
>
Oups sorry look proto_tree_add_item (with FT_BOOLEAN type and bitmask field)
with proto_tree_add_bitmask function (See Readme.dev guide)
proto_tree_add_boolean_bits_format_value(ver_flags_tree,
hf_mih_ack_req, tvb, (offset*8) + 4, 1, FALSE, "%d", tvb_get_bits8(tvb, 4, 1));
may be replace also by proto_tree_add_item
Also checkhf get a warning :
Unused entry: epan/dissectors/packet-mih.c, hf_mih_value
Also some warning with tools fix-encodings-args.pl
Missing also the modification of epan/CMakeLists.txt
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.