Wireshark-bugs: [Wireshark-bugs] [Bug 3917] tvb_new_real_data is prone to memory leak.

Date: Thu, 15 Dec 2011 17:58:29 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3917

Bill Meier <wmeier@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Bill Meier <wmeier@xxxxxxxxxxx> 2011-12-15 20:58:29 EST ---
Re:

  ./plugins/asn1/packet-asn1.c
  leak and dissect a tvb buff in proto_reg_handoff() outside a TRY block.

   proto_reg_handoff_asn1() call read_asn1_type_table() which use tvb functions
   for decoding data from a file but proto_reg_handoff is not inside a TRY
CATCH
   block thus tvb functions could throw uncaught exceptions.


IMO, doing anything with this isn't worth any energy.   :)

1. As Anders noted:

   "I don't think this dissector is used any more so low prio."

2. The dissector default pref is a null ASN1 filename so the code is not
   normally executed.

and so on.....


So: I'm now closing this bug as fixed since I believe all the other cases
reported in this bug of tvb_new_real_data leaking memory have been fixed.

Thanks for the detailed report (it did take a while for us to completely
address it) !

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.