Wireshark-bugs: [Wireshark-bugs] [Bug 6519] CIP dissector: Buildbot crash output: fuzz-2011-10-3

Date: Thu, 3 Nov 2011 05:46:02 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6519

--- Comment #15 from Roland Knall <rknall@xxxxxxxxx> 2011-11-03 05:46:01 PDT ---
(In reply to comment #14)
> Created an attachment (id=7364)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7364) [details]
> Initialize memory with memset
> 
> The memset() in the attached patch should be proper fix.  The rest of the patch
> is just "cleanup" of previous attempts to fix it.  This patch reenables
> dissect_cip_multiple_service_packet_rsp() so if the memset doesn't fix it, the
> bug should still be exposed.
> 
> I had no luck duplicating the problem on Windows (the only system I have access
> to), so the patch should be tested before giving it to the Buildbots.

Ok, I tested your patch with all the fuzz-*pcap files in the entries above and
31495 and the seg-fault is gone. 

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6530 btw prints the warning 
** (process:32593): WARNING **: Dissector bug, protocol CIP, in packet 1274:
More than 1000000 items in the tree -- possible infinite loop

but besides that, this bug seems to be fixed and can be resolved.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.