https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6538
--- Comment #4 from Roland Knall <rknall@xxxxxxxxx> 2011-11-02 23:38:49 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > Why is the code in stringToBytes() so badly written C code?
> > This has to be rewritten with proper code.
> >
>
> Can hex_str_to_bytes() in strutil.h be used?
>
> > Why does this dissector have it's own crc routines?
> > They should be moved to wsutil.
Yes, hex_str_to_bytes() is a viable option, and I am preparing a patch right
now.
Regarding the CRC issue, as openSAFETY uses specialised CRC's which are not
currently implemented, I can not use the predefined ones. Is it an option, that
I move the CRC code into wsutil alltogether, so that other's can use it? The
used polynoms for CRC8 and CRC16 are widely known.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.