https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6462
Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alexis.lagoutte@xxxxxxxxx
Depends on| |6078
--- Comment #1 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-10-28 04:03:31 PDT ---
Your patch is enhance of patch proposed in Bug #6078 but not include
recommendation of Chris :
> You don't append text to proto_trees; you append them to proto_items. And what
> happens if ops is zero? I think it would be better to only call the initial
> proto_item_append_text() if ops is non-zero. And within the for() loop, you
> might consider using the plurality macro to comma-separate the ops, i.e.
> something like:
> proto_item_append_text(item, " %s%c", val_to_str(opcode,
> names_nfsv4_operation, "Unknown"), plurality(ops, '\0', ','));
About the append text use the function proto_tree_get_parent to get the item of
tree.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.