Wireshark-bugs: [Wireshark-bugs] [Bug 6416] Improved CIP and ENIP dissectors

Date: Thu, 27 Oct 2011 18:26:25 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6416

--- Comment #24 from Michael Mann <mmann78@xxxxxxxxxxxx> 2011-10-27 18:26:25 PDT ---
> Oh boy..  Looks like I was reviewing attachment 7223 [details] which was the one prior to
> the fix-encoding-args one.  <sigh> I don't know how that happened (especially
> since bugzilla normally hides obsolete attachments). Sorry about that...
> BTW, we've been having a rash of fuzz failures from the CIP dissector recently.

The current code on the trunk didn't look quite and I was starting to question
my ability to create patches.  Can we try again applying the latest patch in
this bug to the branch?  I've been trying to keep up with the fuzz failures and
they all point to the code being really messed up.  I was going to reopen this
bug to provide a smaller patch that fixed what I thought were "merge mistakes".
 What do you think is the best course of action?  I don't want to revert the
entire patch as a newer smaller patch (that should just be packet-cip.c) should
do the trick (it just may take me a day or so to verify everything).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.