https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5730
Martin Renold <reld@xxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #7282|0 |1
is obsolete| |
Attachment #7301| |review_for_checkin?
Flag| |
--- Comment #7 from Martin Renold <reld@xxxxxxx> 2011-10-25 08:51:43 PDT ---
Created an attachment (id=7301)
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7301)
patch v4
Updated patch that addresses all comments.
It also resolves another conflict with svn trunk, and there is a minor
addition: in packet_hsr.c we check the lsdu_size and display whether it is
correct or not, as we already did in packet_prp.c.
Thanks for your explanation about the if (!tree), I have removed it
from the hsr and supervision dissector. I don't think anyone would
ever notice the performance difference.
About the "ensure we can read 2 bytes" code, you are right it was unnecessary,
exceptions work just as well.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.