Wireshark-bugs: [Wireshark-bugs] [Bug 6459] New: EIGRP dissector cleanup

Date: Fri, 14 Oct 2011 08:34:57 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6459

           Summary: EIGRP dissector cleanup
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: Mac OS X 10.7
            Status: NEW
          Severity: Normal
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: diivious@xxxxxxxxxxx


Created an attachment (id=7241)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=7241)
packet-eigrp.c diffs

Build Information:
wireshark 1.7.0 (SVN Rev 39423 from /trunk)

Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.24.6, with Cairo 1.10.2, with Pango 1.28.4, with
GLib 2.28.8, with libpcap 1.1.1, with libz 1.2.5, without POSIX capabilities,
with threads support, without SMI, without c-ares, without ADNS, without Lua,
with Python 2.7.1, without GnuTLS, without Gcrypt, with MIT Kerberos, without
GeoIP, without PortAudio, without AirPcap.

Running on Mac OS 10.7.2 (Darwin 11.2.0), without locale, with libpcap version
1.1.1, with libz 1.2.5.

Built using llvm-gcc 4.2.1 (Based on Apple Inc. build 5658) (LLVM build
2335.15.00).

--
Cleanup two issues reported by Chris Maynard:

1) Coverity reports a CONSTANT EXPRESSION RESULT bug in CID 1310 at line 1762:

   Fixed if statement


2 tools/checkhf.pl reports the following unused entries 
    bash-3.2$ tools/checkhf.pl epan/dissectors/packet-eigrp.c
    bash-3.2$ 


Ran fuzz-test.sh
bash-3.2$ tools/fuzz-test.sh -p 1 test/eigrp*.pcap
Running ./tshark with args: -nVxr (1 passes)
Starting pass 1:
    test/eigrp-ipx.pcap:  OK
    test/eigrp_ipv6_auth.pcap:  OK
    test/eigrp_ipv6_stub.pcap:  OK
    test/eigrp_ipv6_updates.pcap:  OK
    test/eigrp_rel6_safv4.pcap:  OK
    test/eigrp_rel6_safv6.pcap:  OK
    test/eigrp_rel8_active_sia.pcap:  OK
    test/eigrp_rel8_hmac.pcap:  OK
    test/eigrp_rel8_md5_auth.pcap:  OK
    test/eigrp_rel8_restart.pcap:  OK
    test/eigrp_rel8_saf.pcap:  OK
    test/eigrp_rel8_stub.pcap:  OK

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.