https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5531
Guy Harris <guy@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #7170|review_for_checkin? |review_for_checkin-
Flag| |
--- Comment #8 from Guy Harris <guy@xxxxxxxxxxxx> 2011-10-12 12:34:18 PDT ---
(From update of attachment 7170)
Don't patch Makefile.in; it's a generated file. Don't patch generated
Makefiles, either.
"Whether the C12.22 dissector should verify the crypto for all
releveantmessages" needs a misspells "relevant" and needs a space between it
and "messages".
There are still proto_tree_add_item() calls passing FALSE as the last argument;
they should use the appropriate ENC_ values or combinations of ENC_ values.
All cases where "length" or "*length" is decremented by a value should have
checks to make sure it's >= that value - *before* whatever is being dissected
is dissected.
tvb_offset_exists() checks whether the offset is in the captured packet data;
if the data is in the packet, but wasn't captured, the dissector should attempt
to fetch that data, so that an exception is thrown and the packet reported as
having been cut short by a snapshot length. You should check the reported
length.
What is canonify_unencrypted_header() doing? It's poking around in the
protocol tree in ways that suggest a complicated solution to a problem that
might better be solved in a different fashion.
asn1/c1222/packet-c1222-template.h looks strange - it appears to have two
copies of the contents?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.