https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6153
Jaap Keuter <jaap.keuter@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|Normal |Enhancement
--- Comment #15 from Jaap Keuter <jaap.keuter@xxxxxxxxx> 2011-10-10 21:28:25 CEST ---
Things to improve:
* Go to http://www.wireshark.org/tools/modelines.html and implement a
consistent indentation style.
* in case CSG_REPORT_STRING: {
don't use an elaborate tvb_copy construction, we've got helpers for that:
tvb_get_ephemeral_string(). Look them up in epan/tvbuff.h
* using PROTO_ITEM_SET_HIDDEN is deprecated. Try to remove them.
* data_handle should be of type dissector_handle_t
* This header really is outdated, use the current boilerplate please.
+ * Ethereal - Network traffic analyzer
* Insert alphabetically in the dissector list please, also apply to Cmake list
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.