https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6225
--- Comment #10 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-10-09 08:03:52 PDT ---
Hi,
a quick review...
1) We must remove the old dissector? (packet-xmpp.c)
2) The patch don't apply correctly in trunk (Problem with Makefile.common file)
It is possible to add also change in epan/CMakeLists.txt ?
3)
+ { &hf_xmpp_response_in,
+ { "Response In", "xmpp.response_in",
+ FT_FRAMENUM, BASE_NONE, NULL, 0x0,
+ "The response to this PANA request is in this frame", HFILL }
It is the good description ?
4) There is some tab (spaces) in files, please always the some indentation
(Add modeline information, See README.dev)
5) Use TRUE or FALSE for encoding attribute is deprecated, please use
ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN/ENC_NA (See README.dev)
6) There is 2 Warning with Clang compiler :
packet-xmpp-utils.c:81:9: warning: Value stored to 'xmpp_trans' is never read
xmpp_trans = se_tree_lookup_string(xmpp_info->req_resp, id,
EMEM_TREE_STRING_NOCASE);
packet-xmpp-utils.c:309:21: warning: Value stored to 'unknown_attr_item' is
never read
unknown_attr_item = proto_tree_add_text(tree, tvb,
attr->offset, attr->length,
7) The code is fuzzed ?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.