Wireshark-bugs: [Wireshark-bugs] [Bug 6430] BRP Protocol Preference Addition

Date: Wed, 5 Oct 2011 09:42:30 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6430

--- Comment #6 from Bill Meier <wmeier@xxxxxxxxxxx> 2011-10-05 12:42:28 EDT ---
(In reply to comment #5)
> 
> To be clear on your comments, in order for a change similar to this
> to be accepted, I need to submit changes for BRP and the other protocol that
> uses this UDP port and make them both heuristic?
> 

(Jumping into this conversation and hopefully not confusing the issue).

Unless I'm missing something, there doesn't appear to be any actual Wireshark
dissector registered on UDP port 1958.

However I do see that this port is officially assigned by IANA[1] as follows:

   dxadmind  1958  tcp  CA Administration Daemon    [John_Birrell]
   dxadmind   1958 udp  CA Administration Daemon    [John_Birrell]

This may be what Anders was referencing when he said "registered to a different
protocol" in [2] although I'm not sure.

[1]http://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xml

[2]https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6428#c7


As Jaap indicated, this can be handled by adding a heuristic registration to
your dissector.

Another way (as Anders suggested): Add a port preference [which is by default 0
and thus the dissector is (by default) not registered].

See epan/dissectors/packet-lsc.c for a fairly simple example.

IMHO: Using a port preference would be acceptable.

P.S.: Note that I recently committed some minor changes to the BRP dissector
source.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.