https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6373
--- Comment #19 from Yaniv Kaul <mykaul@xxxxxxxxx> 2011-10-01 11:59:40 PDT ---
(In reply to comment #18)
> Coverity reports 13 new defects against the SPICE dissector, all of the
> UNUSED_VALUE variety and reported as CID's: 1293-1297. They all seem to be
> doing the same thing - calling proto_item_add_subtree() and assigning the
> result to a proto_tree * that isn't used. Any chance of finishing the
> dissection for these?
>
> Here's the list:
>
> 1722: client_message_tree = proto_item_add_subtree(ti,
> ett_common_client_message);
> 2363: inputs_tree = proto_item_add_subtree(ti, ett_inputs_client);
> 2368: inputs_tree = proto_item_add_subtree(ti, ett_inputs_client);
> 2333: main_tree = proto_item_add_subtree(ti, ett_main_client);
> 2339: main_tree = proto_item_add_subtree(ti, ett_main_client);
> 2191: agent_tree = proto_item_add_subtree(ti, ett_spice_agent);
> 2196: agent_tree = proto_item_add_subtree(ti, ett_spice_agent);
> 2201: agent_tree = proto_item_add_subtree(ti, ett_spice_agent);
> 2207: agent_tree = proto_item_add_subtree(ti, ett_spice_agent);
> 2213: agent_tree = proto_item_add_subtree(ti, ett_spice_agent);
> 2218: agent_tree = proto_item_add_subtree(ti, ett_spice_agent);
> 2242: agent_tree = proto_item_add_subtree(ti, ett_spice_agent);
> 2646: caps_tree = proto_item_add_subtree(ti, ett_link_caps);
I'd like to fix some, some sooner rather than later - but not all. I think
commenting them out would just make other (ett_inputs_client, for example),
unused.
How urgent is it?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.