https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6060
Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #7108|review_for_checkin? |review_for_checkin-
Flag| |
--- Comment #14 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-10-01 07:22:26 PDT ---
(From update of attachment 7108)
You need to add packet-ua.h to Makefile.common (and CmakeFile.txt)
The code don't compile under Linux and there is some clang warning :
packet-ua.c: In function ‘DissectUA’:
packet-ua.c:302: error: ‘nLen’ may be used uninitialized in this function
packet-ua.c:371:13: warning: Value stored to 'iOffs' is never read
iOffs = DissectNOE_type(pTvb, pSubTreeNOE, iOffs);
packet-ua.c:619:9: warning: Value stored to 'iOffs' is never read
iOffs += u8Size;
Otherwise, the heuristic looks good, Bill a review about heuristic ?
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.