Wireshark-bugs: [Wireshark-bugs] [Bug 6258] SIP-T/I supported only ITU till date. Added support

Date: Tue, 23 Aug 2011 03:50:33 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6258

--- Comment #4 from Kamal Bhambhani <kamal_bhambhani@xxxxxxxxx> 2011-08-23 03:50:33 PDT ---
I have verified the change. Patch works.
private_data is already being set in packet-sip.c (from sip content-type)

I have also verified it for multipart bodies containing ansi body fragment when
their content-type specifies so.

(In reply to comment #2)
> Hi,
> The patch seems incomplete, there is no setting of the private data.
> A trace to verify the patch with should be nice too.
> 
> At a glance a generic solution would be to introduce a struct in
> packet-multipart.c contaning any parameters in Content type, or the complete
> headers:
> From
> static const multipart_header_t multipart_headers[] = {
> :
>     { "Content-Disposition", NULL },
>     { "Content-Encoding", "e" },
>     { "Content-Id", NULL },
>     { "Content-Language", NULL },
>     { "Content-Length", "l" },
>     { "Content-Transfer-Encoding", NULL },
>     { "Content-Type", "c" },
> };
> stuff that into private data and let the application parse it if need be.
> 
> Regards
> Anders

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.