Wireshark-bugs: [Wireshark-bugs] [Bug 6219] New: [PATCH] Offset calculated incorrectly for sFlow

Date: Mon, 8 Aug 2011 13:25:04 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6219

           Summary: [PATCH] Offset calculated incorrectly for sFlow
                    extended data
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Medium
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: acferen@xxxxxxxxx


Build Information:
andrewf@espresso:~/src/wireshark$ ./wireshark -v
wireshark 1.7.0 (SVN Rev 38363 from /trunk)

Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.20.1, with GLib 2.25.14, with libpcap 1.0.0, with
libz 1.2.3.3, without POSIX capabilities, with threads support, without
libpcre,
without SMI, without c-ares, without ADNS, without Lua, without Python, without
GnuTLS, without Gcrypt, with MIT Kerberos, without GeoIP, without PortAudio,
without AirPcap.

Running on Linux 2.6.32-33-generic, with locale en_US.utf8, with libpcap
version
1.0.0, with libz 1.2.3.3.

Built using gcc 4.4.3.

--
I hit this problem with extended switch data, but the problem exists for
extended router and gateway decodes as well.

dissect_sflow_245_extended_switch
dissect_sflow_245_extended_router
dissect_sflow_245_extended_gateway

all return the new offset not the number of bytes they consumed, however, in
one of two locations the return value is added to the offset.

The fix is to assign to the offset.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.