[bugzilla-daemon@xxxxxxxxxxxxx]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6159

--- Comment #3 from Pascal Quantin <pascal.quantin@xxxxxxxxx> 2011-07-25 10:19:23 PDT ---
Hi Martin,
this code is safe as it is protected by a test on the remaining length a few
lines before:
        if (tvb_length_remaining(tvb, offset) > 0) {
            if (p_pdcp_info->plane == USER_PLANE) {
                if (global_pdcp_dissect_user_plane_as_ip) {
                    tvbuff_t *payload_tvb = tvb_new_subset_remaining(tvb,
offset);
                    switch (tvb_get_guint8(tvb, offset) & 0xf0) {
                        case 0x40:
                            call_dissector_only(ip_handle, payload_tvb, pinfo,
pdcp_tree);
                            break;
                        case 0x60:
                            call_dissector_only(ipv6_handle, payload_tvb,
pinfo, pdcp_tree);
                            break;
                        default:
                            call_dissector_only(data_handle, payload_tvb,
pinfo, pdcp_tree);
                            break;
                    }
                }
                else {
                    proto_tree_add_item(pdcp_tree, hf_pdcp_lte_user_plane_data,
tvb, offset, -1, FALSE);
                }

I tested with a user data PDU containing just the sequence number and it does
not trigger an assert.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.