Wireshark-bugs: [Wireshark-bugs] [Bug 6111] Build fails when HAVE_AIRPCAP: uninit'ed var in main

Date: Mon, 11 Jul 2011 19:29:12 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6111

--- Comment #1 from Guy Harris <guy@xxxxxxxxxxxx> 2011-07-11 19:29:11 PDT ---
That's the default for CMake?  It doesn't first check for the AirPcap SDK
(which you will *not* have if your operating system's name doesn't contain the
string "Windows")?  That's definitely a bug in the CMake configuration.

The other bug is that capture_if_start() appears to completely empty out the
array of interfaces, using interface_opts as a temporary value, and then uses
interface_opts - which might not have been set, if the array of interfaces is
empty - to set airpcap_if_active.  That bug was, apparently, not caught by the
compiler that's used on the only platform where HAVE_AIRPCAP should be on,
namely Windows, so I suppose we should be grateful for the other bug, which
caused this code to be run through GCC with the warnings cranked up.

I suspect that's a result of the AirPcap code being a leftover from before the
multiple-interface changes; note that this means that you might well have a
capture in progress on an AirPcap interface *and* a regular interface at the
same time, which could complicate the UI a bit.  (Note that we already have
interface options that are supported on some interfaces but not others, such as
the "monitor mode" setting; AirPcap introduces more such options, and, if, as,
and when I get around to adding channel-changing support for 802.11 interfaces
to libpcap, there will be even more such options - and those options will be
similar to the ones for AirPcap.)

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.