Wireshark-bugs: [Wireshark-bugs] [Bug 6108] New: FIx missing 'vendor-specific' error code handli

Date: Sun, 10 Jul 2011 16:39:31 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6108

           Summary: FIx missing 'vendor-specific' error code handling for
                    SMPP v3.4/5.0 PDUs
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: bugzilla-admin@xxxxxxxxxxxxx
        ReportedBy: stolj@xxxxxxxxxx


Created an attachment (id=6642)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6642)
patch to fix SMPP v3.4/5.0 to support vendor-specific error codes

Build Information:
wireshark 1.7.0 (SVN Rev 37945 from /trunk)

Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GTK+ 2.22.0, with GLib 2.26.0, with libpcap 1.1.1, with
libz 1.2.5, without POSIX capabilities, without libpcre, without SMI, without
c-ares, without ADNS, without Lua, without Python, without GnuTLS, with Gcrypt
1.4.5, with MIT Kerberos, without GeoIP, without PortAudio, without AirPcap.

Running on Linux 2.6.35.13-92.fc14.i686, with locale en_US.utf8, with libpcap
version 1.1.1, with libz 1.2.5, Gcrypt 1.4.5.

Built using gcc 4.5.1 20100924 (Red Hat 4.5.1-4).

--
This is a patch against SVN trunk.

The current support for SMPP v3.4/5.0 lacks the ability to classify specific
SMPP PDUs. I.e. if the submit_sm_resp PDU contains a .command_status from a
reserved value range, OR from the vendor-specific value range (0x400-0x4FF),
therefore NO SMPP PDU dissector identified packet is displayed in the list. 

This can be considered an buggy behavior, due that most users will expect the
submit_sm_resp PDU to be displayed in Wireshark. 

The attached patch fixes this, by ensuring that ALL response PDUs are
displayed, and the corresponding description text for the reserved or
vendor-specific error code is displayed.

Please review and add.

Stipe Tolj
Kannel Software Foundation - http://www.kannel.org/

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.