Wireshark-bugs: [Wireshark-bugs] [Bug 5966] VoIP call flow graph displays BICC APM as a BICC ANM

Date: Fri, 1 Jul 2011 19:14:48 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5966

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6603|                            |review_for_checkin?
               Flag|                            |

--- Comment #1 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-07-01 19:14:46 PDT ---
Created an attachment (id=6603)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6603)
ep_alloc() the tap_rec passed to tap_queue_packet() .

>From doc/README.tapping:

IF the tap is going to return private data using the last parameter to
tap_queue_packet() and IF the protocol can appear multiple times inside the
same packet, you will have to make sure that each instance of
tap_queue_packet() is using its own instance of private struct variable
so they don't overwrite each other.

This was the case here, so I changed the static allocation of tap_rec to be
ep_alloc'd.  I also tried to clean up the Info column a bit.  With this patch
applied, the graph now shows the APM and ANM correctly instead of 2 ANM's. 
Please test.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.