https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6078
Chris Maynard <christopher.maynard@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #6594|review_for_checkin? |review_for_checkin-
Flag| |
--- Comment #6 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-06-30 19:12:27 PDT ---
(From update of attachment 6594)
You don't append text to proto_trees; you append them to proto_items. And what
happens if ops is zero? I think it would be better to only call the initial
proto_item_append_text() if ops is non-zero. And within the for() loop, you
might consider using the plurality macro to comma-separate the ops, i.e.
something like:
proto_item_append_text(item, " %s%c", val_to_str(opcode,
names_nfsv4_operation, "Unknown"), plurality(ops, '\0', ','));
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.