Wireshark-bugs: [Wireshark-bugs] [Bug 6017] No Cisco FabricPath protocol dissector included

Date: Fri, 24 Jun 2011 14:55:50 -0700 (PDT)

--- Comment #3 from Leonard Tracy <letracy@xxxxxxxxx> 2011-06-24 14:55:47 PDT ---
(In reply to comment #2)
> +  //dissector_add("ethertype", ETHERTYPE_DTAG, fp_handle);
> +  heur_dissector_add ("eth", dissect_fp_heur, proto_fp);
> I would prefer registration of the ethertype (using dissector_add_uint()),
> i.s.o. heuristically process *all* ethernet frames, most of which are unlikely
> to be MiM packets for most people. 
> If that's not feasible a preference (by default off) for heuristics would be
> preferred. See packet-hilscher.c for the example. packet-tte.c should be
> probably done the same way.

Will take a look in the next week.  Thanks for the comments, I didn't see any
emails for these or I would have gotten them done already.

I went with heur simply because the example ethertype method resulted in the
eth dissector processing the ethernet addresses and forwarding the remainder of
the frame to my dissector.  I wanted this dissector to process the hierarchical
MAC addresses and the tag both and then to forward the remainder of the packet
back to the eth dissector.  Is it possible to do this without using the
heur_dissector?  When I searched around for a way to do this, the only
recommendation I found was to do what I've done.


Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.