Wireshark-bugs: [Wireshark-bugs] [Bug 3500] Add Python embedding to Windows makefiles

Date: Thu, 23 Jun 2011 14:20:10 -0700 (PDT)

--- Comment #35 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-06-23 14:20:09 PDT ---
(In reply to comment #34)
> I have MSVC2008EE so Python 2.7.2 must have been built with MSVC2008EE then?
Yes, that is almost certainly the case - well either MSVC2008EE or MSVC2008.

> (I'm not seeing the crash).  I just went to the Python download page to grab
> the installer and the Windows versions don't include source (so I never tried
> to build Python).  

Me either.  If I ever find the time, maybe I will try to download the source
and build it.

> Does that mean I have to build the Python DLL with Wireshark to ensure its MSVC
> version independence?  Does this make it a wireshark-win*-libs candidate?

Good question.  If we do build python ourselves from source on Windows, then
that *should* eliminate this problem.  Otherwise we might find ourselves doing
lots of ugly checks in config.nmake to find out which version of python is
installed, then looking up which version of MSVC it was compiled against then
seeing if the MSVC_VARIANT matches, and only then setting PYTHON_EMBED=1.  Or
we could add other checks so if you're using MSVC X, that you also have python
Y installed; otherwise bail out and indicate the version of python required. 
That won't help for MSVC 2010 though, at least not yet.  But we could still
bail out there too and indicate that PYTHON_EMBED is not yet supported for it
and to either disable it or use MSVC 2008 instead.

> Or Should config.nmake be modified to only allow PYTHON_EMBED=1 if
> MSVC_VARIANT=MSVC2008 because that's what the Windows installer appears to
> produce?

Well, if you're running python 2.4.4 (for example), then that won't work
because it wasn't compiled with MSVC 2008, as indicated in config.nmake.  And
then the when some future version of python is released that was compiled
against a later version of MSVC, such as MSVC 2010, then the same thing will
happen again.

Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.