Wireshark-bugs: [Wireshark-bugs] [Bug 5975] Buildbot crash output: fuzz-2011-05-31-31883.pcap

Date: Tue, 31 May 2011 20:42:02 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5975

--- Comment #1 from Guy Harris <guy@xxxxxxxxxxxx> 2011-05-31 20:42:01 PDT ---
If this is a result of checking in the openSAFETY dissector, then:

Unfortunately, the openSAFETY dissector, which is a built-in dissector,
registers itself as a heuristic dissector for SERCOS III, the dissector for
which is a plugin dissector.

Perhaps heur_dissector_add() should report an error to the user, rather than
aborting, if the heuristic dissector table in question doesn't exist.  If it
were to check the WIRESHARK_ABORT_ON_DISSECTOR_BUG environment variable, and:

    if it's set, abort if the heuristic dissector table doesn't exist;

    if it's not set, report an error to the user;

that should allow the build process to catch typos in the heuristic dissector
table name but avoid having *Shark crash if plugins are missing.

This also raises the question "why is the SERCOS III plugin apparently not
being loaded when we're doing the fuzz testing?"  If the plugins aren't getting
loaded, that means they're not getting fuzz tested.

This also raises the question of whether the SERCOS III dissector should be
made a built-in dissector.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.