Wireshark-bugs: [Wireshark-bugs] [Bug 5902] RTP Player inserts max 1000 samples of silence

Date: Fri, 13 May 2011 12:06:50 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5902

Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jeff.morriss.ws@xxxxxxxxx
         Resolution|                            |FIXED

--- Comment #3 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-05-13 12:06:48 PDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > The RTP analysis / player isn't really equipped to handle anything other than
> > PCMA and PCMU streams. Other options, like T.38, Silence suppression, etc.
> > aren't really handled. The measures put in place are there to make this core
> > functionality work, even in the presence of 'malicious' files. Bug 4119 is an
> > example of that. 
> > It would take some serious work to improve on this, which someone(s) should
> > find the time for.
> 
> Well, the insertion of silent samples as compensation for suppressed silence
> works great. I tried to raise the limit from 1000 to 14400000 (30 minutes) and
> compiled on linux and it worked perfectly.
> 
> IMHO the limit to 1000 samples renders this feature unusable - feature that was
> requested in the "bug" 2270
> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2270

If I use 14400000 I still get a crash with the trace from bug 4119.  Admittedly
it is an X error, not an out-of-memory error:

~~~
The program 'lt-wireshark' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadAlloc (insufficient resources for operation)'.
  (Details: serial 17072 error_code 11 request_code 53 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)
~~~

I suppose this is an X or player bug, but I don't know what to do about it.

I increased the maximum number of frames to 240,000 (which consistently does
not crash for me) in rev 37130.  I hope that's enough, at least until someone
can rework it all as Jaap suggests.  If not, feel free to reopen the bug.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.