https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5863
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jeff.morriss.ws@xxxxxxxxx
--- Comment #3 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2011-05-10 19:08:47 PDT ---
This patch basically looks good (though I had to manually apply a couple parts
because trunk has been updated), but:
- tvb_memcpy() should be used instead of memcpy()+tvb_get_ptr()
- Shouldn't the RSA-NULL-MD5 and RSA-NULL-SHA values be stored somewhere and
have a macro? (I admit I'm not familiar with the decryption dissectors.)
- (the biggest problem): adding DTLS as a heuristic dissector on UDP might make
sense, but the heuristics in looks_like_dtls() are way too weak: without
strengthening, DTLS will pick up lots of stuff that is not DTLS.
I checked in the packet-ssl-utils.c change in rev 37058 but will leave the rest
for resolution of at least the last point above.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.