https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5767
--- Comment #16 from Alexis La Goutte <alexis.lagoutte@xxxxxxxxx> 2011-04-17 02:21:18 PDT ---
Hi,
About BT-uTP dissector :
I think it is good idea to create a new bug id for this protocol
I not found sample of bt-utp trafic in pcap file ?
The port is assigned by IANA ? otherwise it would add a preference to modify
the port or make a heuristic dissector (See README.heuristic docs)
+ proto_tree_add_uint(tree, hf_bt_utp_connection_id, tvb, 2, 2,
connection_id);
+ proto_tree_add_uint(tree, hf_bt_utp_timestamp_ms, tvb, 4, 4,
timestamp_ms);
...
use directly proto_tree_add_item, the connection_id and timestamp_ms is not
needed and not used after
The checkAPIs is not happy :
./tools/checkAPIs.pl epan/dissectors/packet-bt-utp.c
Warning: epan/dissectors/packet-bt-utp.c does not have an SVN Id tag.
Error: Found C++ style comments in epan/dissectors/packet-bt-utp.c
Error: Found deprecated APIs in epan/dissectors/packet-bt-utp.c: dissector_add
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.