Wireshark-bugs: [Wireshark-bugs] [Bug 5770] Add conversation tracking to ICMP.

Date: Tue, 22 Mar 2011 12:05:31 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5770

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6043|0                           |1
        is obsolete|                            |
   Attachment #6045|review_for_checkin?         |
               Flag|                            |
   Attachment #6045|0                           |1
        is obsolete|                            |
   Attachment #6061|                            |review_for_checkin?
               Flag|                            |

--- Comment #14 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2011-03-22 12:05:30 PDT ---
Created an attachment (id=6061)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6061)
Latest patch with improved tracking.

This latest patch adds the ICMP checksum as part of the conversation key.  This
was added after I tested a lengthy capture session where I allowed the sequence
numbers to wrap back around again.

I also added other improvements to prevent things like a reply matching a
request that comes after the reply and to avoid having multiple requests
indicate a match to a single reply.

Some of the capture files I used during this anomaly testing I've attached
already.  Mostly they are hand-tweaked portions of the long-running capture
where I allowed the sequence numbers to wrap.  In some cases, I reordered
packets to obtain the test case I was looking for.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.