Wireshark-bugs: [Wireshark-bugs] [Bug 5753] New dissector for the openSAFETY protocol

Date: Sun, 20 Mar 2011 12:43:40 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5753

Roland Knall <rknall@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6014|0                           |1
        is obsolete|                            |
   Attachment #6039|                            |review_for_checkin?
               Flag|                            |

--- Comment #8 from Roland Knall <rknall@xxxxxxxxx> 2011-03-20 12:43:38 PDT ---
Created an attachment (id=6039)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6039)
A new version of the patch, correcting the issues, mentioned in the bug report.

I fixed the following issues:

(From Guy Harris)
 - identation is now 4 spaces
 - if the type cannot be determined, the dissector returns FALSE. If there
would be another type, the underlying network would fail per definition
 - SercosIII dissector now correctly uses subdissector, and the comment has
been corrected
 - private data uses ep_alloc now

(From Jakub Zawadzki)
 - cleanup with ep_strdup and ep_alloc0
 - removed unnecessary _U_ and cleaned up function prototypes

 - fuzz testing this dissector is not necessary. The standard for openSAFETY is
pretty strict what you can send (even down to the small bytes in the payload).
But I have stress-tested my plugin in an environment where up to 100 so called
Safety Nodes where communicating, and it holds up. Additionally the plugin will
be tested in similar environment on a daily basis in our company's daily
business.

Thank you both, for your help so far, btw.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.