Wireshark-bugs: [Wireshark-bugs] [Bug 5654] dissector for DVB-CI (Common Interface)

Date: Tue, 8 Mar 2011 01:24:26 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5654

--- Comment #16 from Martin Kaiser <wireshark@xxxxxxxxx> 2011-03-08 01:24:20 PST ---

Hi Bill,

(In reply to comment #13)
> Note: I took the liberty of making a few minor changes before i commited the
> new dissector.
> 
> If there are any concerns as to the changes I made please let me know (or feel
> free to submit a patch).

thanks a lot for merging the dissector, that's really good news :)

The changes you made look ok, I haven't checked them in detail yet. In fact, I
was unsure about how much error checking I have to do and I was wondering if
the column code was a bit too clumsy.

> Question: It seems to me that it might be useful to be able to filter on the 
> "event" field in the header. What do you think ?

You're right. When I saw this (just before submitting the patch), I couldn't
think of a quick way to introduce an hf_... variable without changing the way
the pseudo-header is displayed. I'll look at this again and submit a patch to
fix this (this will take some time, I'll be busy the next weeks).

Best regards,

   Martin

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.