Wireshark-bugs: [Wireshark-bugs] [Bug 5675] Rev 35862 - Changes made to airpcap dialog prevent p

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 10 Feb 2011 11:00:48 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5675

--- Comment #1 from Guy Harris <guy@xxxxxxxxxxxx> 2011-02-10 11:00:45 PST ---
The right way to mark a parameter as unused is to put _U_ after it (it expands
to the appropriate __attribute__ value on compilers that support it and expands
to nothing on compilers that don't), not to do a self-assignment.  Just do

    airpcap_add_key_to_list(GtkListStore *key_list_store, gchar* type, gchar*
key, gchar* ssid _U_)

or, so that we get a warning if we end up never using it

    airpcap_add_key_to_list(GtkListStore *key_list_store, gchar* type, gchar*
key, gchar* ssid
#ifndef HAVE_AIRPDCAP
        _U_
#endif
        )

(also not as nice-looking as one would like, but less of a hack than
self-assigning).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.