Wireshark-bugs: [Wireshark-bugs] [Bug 5635] Create a ETSI TETRA dissector for wireshark

Date: Wed, 2 Feb 2011 05:06:51 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5635

--- Comment #21 from Holger Freyther <zecke@xxxxxxxxxxx> 2011-02-02 05:06:50 PST ---
(In reply to comment #19)
> Base code + patches Committed revision 35753, 35754 and 35755.
> 
> Comments on code changes

> - All C++ style comments (//) must be replaced by "/*" for portabillity
> reasons.

sorry.. my vi pattern was not right... I thought I replaced all occurences.

> - Please move proto_register_tetra() to the end of the fie to keep with the
> style of other dissectors.
> - Please use proto_tree_add_item() isf _uint_ _bolean_ etc if the value isn't
> needed.
> - check_col() is no longer needed.

I am looking into the others.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.