Wireshark-bugs: [Wireshark-bugs] [Bug 5631] New: Cleanup 802.11 Dissector : Rework Prism Header

Date: Sat, 29 Jan 2011 09:31:56 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5631

           Summary: Cleanup 802.11 Dissector : Rework Prism Header
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: alexis.lagoutte@xxxxxxxxx


Build Information:
TShark 1.5.1 (SVN Rev 35697 from /trunk)

Copyright 1998-2011 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GLib 2.26.0, with libpcap 1.1.1, with libz 1.2.3.4, with
POSIX capabilities (Linux), without libpcre, with SMI 0.4.8, with c-ares 1.7.3,
with Lua 5.1, without Python, with GnuTLS 2.8.6, with Gcrypt 1.4.5, with MIT
Kerberos, with GeoIP.

Running on Linux 2.6.35-23-generic, with libpcap version 1.1.1, with libz
1.2.3.4.

Built using gcc 4.4.5.
--
Hi,

A patch to rework the Prism Header, Prism Header is a basic TLV..
* Remove (horrible !!) Macro
* Remove not needed struct (val_80211, prism_hdr)
* Rename Header Field (hf_prism => hf_80211_prism)
* Remove Warning from checkhf :
    Unused entry: epan/dissectors/packet-ieee80211.c, hf_prism_signal_data
    ERROR: NO ARRAY: epan/dissectors/packet-ieee80211.c, hf_prism_
    Unused entry: epan/dissectors/packet-ieee80211.c, hf_prism_sq_data
    Unused entry: epan/dissectors/packet-ieee80211.c, hf_prism_msgcode
    Unused entry: epan/dissectors/packet-ieee80211.c, hf_prism_istx_data
    Unused entry: epan/dissectors/packet-ieee80211.c, hf_prism_rate_data
    Unused entry: epan/dissectors/packet-ieee80211.c, hf_prism_frmlen_data
    Unused entry: epan/dissectors/packet-ieee80211.c, hf_prism_msglen
    Unused entry: epan/dissectors/packet-ieee80211.c, hf_prism_noise_data
    ERROR: NO ARRAY: epan/dissectors/packet-ieee80211.c, hf_


The code is checked and fuzzed a sample of Prism Header is available in
pcapr.net (
http://www.pcapr.net/view/fernpromero/2010/3/6/4/prismheader.cap.html )

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.