Wireshark-bugs: [Wireshark-bugs] [Bug 5466] New: Improve dissection of bit-oriented fields, text

Date: Sat, 4 Dec 2010 14:26:35 -0800 (PST)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5466

           Summary: Improve dissection of bit-oriented fields, text
                    fields, and parameter lists in packet-scsi*.c
           Product: Wireshark
           Version: SVN
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: realrichardsharpe@xxxxxxxxx


Build Information:
Version 1.5.0 (SVN Rev 35119 from /trunk)

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.22.0, with GLib 2.26.0, with libpcap 1.1.1, with
libz 1.2.5, with POSIX capabilities (Linux), without libpcre, without SMI,
without c-ares, without ADNS, without Lua, without Python, with GnuTLS 2.8.6,
with Gcrypt 1.4.5, with MIT Kerberos, without GeoIP, without PortAudio, without
AirPcap.

Running on Linux 2.6.35.6-48.fc14.x86_64, with libpcap version 1.1.1, with libz
1.2.5, GnuTLS 2.8.6, Gcrypt 1.4.5.

Built using gcc 4.5.1 20100924 (Red Hat 4.5.1-4).

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
I wanted to be able to search on bit-oriented fields by using searches like
scsi.cdb.control.naca but that is currently not possible. I also want the
parameter lists for Persistent Reservation command dissected properly.

In addition, Chris Maynard pointed out:

" It looks like there are other bit-oriented fields besides
hf_scsi_control that could benefit from this as well: hf_scsi_inquiry_flags,
hf_scsi_modesel_flags, ...

There also seem to be a lot of proto_tree_add_text() calls (I count 186 of
them).  I haven't looked at them all, but I suspect most would be better added
using proto_tree_add_item() so those fields could be filterable as well."

As I change these things I will post patches here for possible inclusion in a
future version of Ethereal, errr, I mean Wireshark.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.