Wireshark-bugs: [Wireshark-bugs] [Bug 5196] Support for dissecting WSC 2.0 and Wi-Fi P2P

Date: Sun, 24 Oct 2010 12:45:14 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5196

--- Comment #19 from Bill Meier <wmeier@xxxxxxxxxxx> 2010-10-24 15:45:11 EDT ---
Looking a bit more at the dissector I see:

a. The dissector is registered as:

  proto_p2p = proto_register_protocol("Wi-Fi Direct", "P2P", "p2p");


b. The filter names are as follows:

  static hf_register_info hf[] = {
    { &hf_p2p_attr_type,
      { "Attribute Type", "p2p.type",
        FT_UINT8, BASE_DEC, VALS(p2p_attr_types), 0x0, NULL, HFILL }},


Noting comments #6 & #7 IMHO the registration and the 
filter names should be consistent with the dissector name.

Something like:

  proto_p2p = proto_register_protocol("Wi-Fi P2P", "WiFi-P2P", "wifi_p2p");

  static hf_register_info hf[] = {
    { &hf_p2p_attr_type,
      { "Attribute Type", "wifi_p2p.type",
        FT_UINT8, BASE_DEC, VALS(p2p_attr_types), 0x0, NULL, HFILL }},

However, I'll defer to Jaap (since he made the original comment on this)
 (or to any of the other core developers who may have an opinion).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.