Wireshark-bugs: [Wireshark-bugs] [Bug 2706] CFM - Incorrect parsing of Test TLV

Date: Wed, 13 Oct 2010 19:44:38 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2706

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5298|                            |review_for_checkin?
               Flag|                            |

--- Comment #3 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-10-13 19:44:34 PDT ---
Created an attachment (id=5298)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5298)
Patch that excludes pattern type from length for TEST_TLV.

(In reply to comment #2)
> Can you point us to the documentation where you found the recommendation to
> *not* include the pattern type field in the field length?

I think he is right.  Refer to section 9.3 LBM PDU of
http://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-Y.1731-200802-I!!PDF-E&type=items.

In particular, from 9.3-4: "Length: Identifies size, in octets, of the Value
field containing the test pattern and CRC-32."

Note that it does NOT state, "... of the Value field containing the pattern
type, test pattern and CRC-32."

Attached is a patch that fixes this.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.