https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5295
Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |jeff.morriss.ws@xxxxxxxxx
Resolution| |FIXED
--- Comment #2 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2010-10-13 18:11:30 PDT ---
Personally I'd use some macros for these values:
+ case 0x01: /* Start-Control-Connection-Request */
(and in the corresponding value_string's), but otherwise:
Nice. Thanks, checked in rev 34504, with a change to move dissect_pptp()
towards the end of the file (alleviating the need for all the forward
declarations).
BTW, it would be nice to have a wiki page for this protocol and/or some sample
captures (on Wireshark's wiki) for testing.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.