Wireshark-bugs: [Wireshark-bugs] [Bug 4014] ICMP: Add ID and seq # to Info column

Date: Tue, 14 Sep 2010 14:43:48 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4014

--- Comment #19 from Stephen Fisher <steve@xxxxxxxxxxxxxxxxxx> 2010-09-14 15:43:46 MDT ---
(In reply to comment #14)
> Created an attachment (id=4796)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=4796) [details]
> Patch to try to clean up seq # BE/LE "messyness".
> 
> It attempts to use heuristics to determine the seq # byte ordering based on
> the ID field.

I like this idea.

> Of course if these heuristics are not robust enough (say if the case is that
> Windows 7 turns out to have fixed their incorrect byte ordering of the ICMP
> fields), then we might need to add a preference after all.

We could add an icmp preference item to let the user disable that heuristic and
to display both the big and little endian representations.  It may be worth
"overloading" the display filter field for both the little and big endian
representations so the user doesn't have to think of which to type in, similar
to how I did that with the TCP window size recently (assigning the value from
the packet and the optional scaled window size as the same display filter).

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.