Wireshark-bugs: [Wireshark-bugs] [Bug 5186] New: [NAS EPS] EPS Quality of Service IE decoding is

Date: Mon, 6 Sep 2010 02:56:00 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5186

           Summary: [NAS EPS] EPS Quality of Service IE decoding is wrong
           Product: Wireshark
           Version: 1.5.x (Experimental)
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Low
         Component: Wireshark
        AssignedTo: wireshark-bugs@xxxxxxxxxxxxx
        ReportedBy: pascal.quantin@xxxxxxxxx


Pascal Quantin <pascal.quantin@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5128|                            |review_for_checkin?
               Flag|                            |

Created an attachment (id=5128)
 --> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=5128)
Patch fixing EPS QoS IE decoding

Build Information:
Version 1.5.0 (SVN Rev 34064 from /trunk)

Copyright 1998-2010 Gerald Combs <gerald@xxxxxxxxxxxxx> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.12.12, (32-bit) with GLib 2.16.6, with libpcap 1.0.0, with
libz 1.2.3.3, without POSIX capabilities, without libpcre, without SMI, without
c-ares, without ADNS, without Lua, without Python, with GnuTLS 2.4.2, with
Gcrypt 1.4.1, with MIT Kerberos, without GeoIP, without PortAudio, without
AirPcap.

Running on Linux 2.6.26-2-686-bigmem, with libpcap version 1.0.0, with libz
1.2.3.3, GnuTLS 2.4.2, Gcrypt 1.4.1.

Built using gcc 4.3.2.

Wireshark is Open Source Software released under the GNU General Public
License.

Check the man page and http://www.wireshark.org for more information.
--
The attached patch fixes the decoding of the maximum/guaranteed bit rates for
uplink/downlink.

With current source code, the following PDU:
27 00 00 00 00 02 62 00 c5 05 05 03 87 97 87 97 06 21 30 10 02 30 01
decodes as:
Non-Access-Stratum (NAS)PDU
    0010 .... = Security header type: Integrity protected and ciphered (2)
    .... 0111 = Protocol discriminator: EPS mobility management messages (7)
    Message authentication code: 0x00000000
    Sequence number: 2
    0110 .... = EPS bearer identity: 0x06
    .... 0010 = Protocol discriminator: EPS session management messages (2)
    Procedure transaction identity: 0
    NAS EPS session management messages: Activate dedicated EPS bearer context
request (0xc5)
    0000 .... = Spare half octet: 0
    .... 0101 = Linked EPS bearer identity: EPS bearer identity value 5 (5)
    EPS quality of service
        Length: 5
        Quality of Service Class Identifier (QCI): QCI 3 (3)
        Maximum bit rate for uplink : 0 kbps
        Maximum bit rate for downlink : 0 kbps
        Guaranteed bit rate for uplink : 0 kbps
        Guaranteed bit rate for downlink : 0 kbps
    Traffic Flow Template
        Length: 6
        001. .... = TFT operation code: Create new TFT (1)
        ...0 .... = E bit: Parameters list is not included
        .... 0001 = Number of packet filters: 1
        Packet filter 0
            0011 .... = Packet filter direction: Bidirectional (3)
            .... 0000 = Packet filter identifier: 0
            Packet evaluation precedence: 0x10 (16)
            Packet filter length: 0x02 (2)
            Packet filter component type identifier: Protocol identifier/Next
header type (48)
                Protocol/header: 0x01

The value 0 for the different bit rates is invalid.

With the patch applied, it decodes as:
Non-Access-Stratum (NAS)PDU
    0010 .... = Security header type: Integrity protected and ciphered (2)
    .... 0111 = Protocol discriminator: EPS mobility management messages (7)
    Message authentication code: 0x00000000
    Sequence number: 2
    0110 .... = EPS bearer identity: 0x06
    .... 0010 = Protocol discriminator: EPS session management messages (2)
    Procedure transaction identity: 0
    NAS EPS session management messages: Activate dedicated EPS bearer context
request (0xc5)
    0000 .... = Spare half octet: 0
    .... 0101 = Linked EPS bearer identity: EPS bearer identity value 5 (5)
    EPS quality of service
        Length: 5
        Quality of Service Class Identifier (QCI): QCI 3 (3)
        Maximum bit rate for uplink : 1024 kbps
        Maximum bit rate for downlink : 2048 kbps
        Guaranteed bit rate for uplink : 1024 kbps
        Guaranteed bit rate for downlink : 2048 kbps
    Traffic Flow Template
        Length: 6
        001. .... = TFT operation code: Create new TFT (1)
        ...0 .... = E bit: Parameters list is not included
        .... 0001 = Number of packet filters: 1
        Packet filter 0
            0011 .... = Packet filter direction: Bidirectional (3)
            .... 0000 = Packet filter identifier: 0
            Packet evaluation precedence: 0x10 (16)
            Packet filter length: 0x02 (2)
            Packet filter component type identifier: Protocol identifier/Next
header type (48)
                Protocol/header: 0x01

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.