Wireshark-bugs: [Wireshark-bugs] [Bug 5106] Add emem_tree_lookup32_array_le_last() or equivalent

Date: Mon, 23 Aug 2010 12:44:35 -0700 (PDT)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5106

Chris Maynard <christopher.maynard@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #5 from Chris Maynard <christopher.maynard@xxxxxxxxx> 2010-08-23 12:44:29 PDT ---
(In reply to comment #4)
> Hmmm, I don't think I've an example. I'll have to look into it again to see if
> I can come up with one.

So I guess I was too focused on the README.request_response_tracking document
and forgot about the conversation-related help in README.developer. Well, I
looked at that document again today and found what I needed in 2.2.9, which I
believe I is what you probably had in mind in comment #2:

    if (conversation == NULL || (conversation->setup_frame != pinfo->fd->num))
{

So, I made this minor modification, reduced the key by 1 (removing the frame
number) and changed my se_tree_lookup32_array_le_last() calls back to
se_tree_lookup32_array().  I don't really know what the performance impact is -
better, same, worse - but everything is working as before using the existing
API's.

I assume nobody else thinks se_tree_lookup32_array_le_last() is going to be
useful, so I'm closing this bug.  Thanks Jaap.

-- 
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.